Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Generate Liquid Blocks #5088

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Feat: Generate Liquid Blocks #5088

merged 1 commit into from
Dec 16, 2024

Conversation

jamesmengo
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

jamesmengo commented Dec 12, 2024

Copy link
Contributor

Unused exports (1)

Filename exports
packages/theme/src/cli/utilities/generator.ts SECTION_TYPES

Unused types (3)

Filename types
packages/theme/src/cli/utilities/generator.ts SectionType
TemplateType
packages/theme/src/cli/services/generate/blocks.ts BlockGeneratorOptions

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.29% 8771/11650
🟡 Branches 70.57% 4277/6061
🟡 Functions 75.04% 2294/3057
🟡 Lines 75.84% 8293/10935

Test suite run success

1975 tests passing in 896 suites.

Report generated by 🧪jest coverage report action from 05db127

@jamesmengo jamesmengo changed the base branch from jm/generators to jm/generator_directory_check December 12, 2024 01:29
@jamesmengo jamesmengo force-pushed the jm/generator_directory_check branch 2 times, most recently from c66bc35 to 9c3b4fc Compare December 12, 2024 01:38
@jamesmengo jamesmengo force-pushed the jm/generator_directory_check branch from 9c3b4fc to 2ef939d Compare December 12, 2024 01:39
@jamesmengo jamesmengo force-pushed the jm/generator_directory_check branch from 2ef939d to a32c4f8 Compare December 12, 2024 01:59
@jamesmengo jamesmengo changed the base branch from jm/generator_directory_check to jm/generators December 12, 2024 17:52
@jamesmengo jamesmengo merged commit 594b08b into jm/generators Dec 16, 2024
1 check passed
@jamesmengo jamesmengo deleted the jm/blocks_generator branch December 16, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant